fix: fix compilation issue #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lykling
commented
Jan 25, 2026
lykling
commented
- lock abseil-cpp to version 20250127.1 to avoid compatible issue of protobuf
Contributor
There was a problem hiding this comment.
Pull request overview
Pins abseil-cpp to a specific version to resolve a Bazel build compilation break caused by protobuf/abseil incompatibilities.
Changes:
- Update
abseil-cppdependency version to20250127.1. - Add a
single_version_overrideto lockabseil-cppat the same version across the module graph.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MODULE.bazel
Outdated
Comment on lines
46
to
47
| # the target `if_constexpr` of `absl/utility/BUILD.bazel` removed or | ||
| # migrated in newer versions, which depended by protobuf |
There was a problem hiding this comment.
The explanatory comment has grammatical issues that make the rationale harder to follow (e.g., "removed or migrated" is missing a verb, and "which depended by protobuf" should be phrased as "which protobuf depends on"). Please reword these lines for clarity.
Suggested change
| # the target `if_constexpr` of `absl/utility/BUILD.bazel` removed or | |
| # migrated in newer versions, which depended by protobuf | |
| # In newer versions, the target `if_constexpr` in `absl/utility/BUILD.bazel` | |
| # that protobuf depends on has been removed or migrated. |
- lock abseil-cpp to version 20250127.1 to avoid compatible issue of protobuf Signed-off-by: Pride Leong <[email protected]>
lykling
force-pushed
the
fix_compilation_issue_dev
branch
from
8502562 to
dc2851e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.